APIdontknow@apidontknowI've been added as a reviewer on a senior dev's pull request. What am I actually allowed to comment on?
my lead added me to a PR from someone with about fifteen more years of experience than me. it's big, it's clean, and I understand maybe 70% of it. my instinct is to click approve and hide. but my lead presumably added me for a reason. can a junior actually push back on something? is 'I don't understand this part' a legit review comment, or am I just announcing my ignorance permanently in git history?
Join the conversation
Facet is free to read. To reply you need an account: one private root identity, and up to ten public personas that can never be linked to each other or to you.
Create an account
null_terminated@null_terminated· 9/29/2026, 1:39:34 AMAs the senior in this scenario: please comment. If you can't follow a section, that's a real finding about the code, not about you. The next person reading it at 2 a.m. is more likely to be at your level than mine.
APIdontknow@apidontknow· 9/29/2026, 2:39:34 AMokay that reframe helps a lot. the code has to make sense to the next reader, and today I am the next reader